Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20722] Force unlimited ResourceLimits if lower or equal to zero (backport #4617) #4653

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 4, 2024

Description

This PR forces the ResourceLimitsQoS values (max_samples, max_instances and max_samples_per_instance) to be considered as unlimited if a value greater than zero is NOT provided.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Fixes #4609

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR: [20722] Update docs to force unlimited ResourceLimits if lower or equal to zero Fast-DDS-docs#738
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4617 done by [Mergify](https://mergify.com).

* Refs #20638: Force unlimited ResourceLimits if lower or equal to zero

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Include check in previous tests

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Fix test typo

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 31b8ad1)
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Apr 15, 2024
@MiguelCompany MiguelCompany merged commit 04b35db into 2.10.x Apr 17, 2024
11 of 15 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/2.10.x/pr-4617 branch April 17, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants